Open gcanyon opened 5 years ago
Case 1 good to go.
Case 2 I would not call abug. More like an oversight that never got addressed when folding as implemented.
Case 3 That the hits don't appear is certainly an issue. I think that when searching, unfolding everything is a good idea, because then I could at least interact with the object hit upon. Clearing the search field should probably re-fold the way it was before the search then. That is what a user would expect. The golden rule is don't change anything in the UI the end user doesn't want or expect.
Case 4 is irrelevant if case 3 (unfolding everything) is used.
Here's the behavior I'm seeing:
Case 1.
Case 2.
Case 3.
The question of whether to automatically un-fold groups because controls in them match the search is unresolved in my mind, but I lean toward ditching folding when searching. As you say, though, merely ignoring folding while searching would mean that selecting a control and then clearing the search would re-hide the control in the fold. Bookmarking the control seems like a poor solution to this. Iteratively clearing folding to guarantee that highlighted controls will display when the search is cleared would actually be fairly easy, but would it make sense to do it? It seems like a pretty obscure method, if this is the behavior:
Case 4.