Updated 0001-fix-building-without-safebrowsing.patch does not work with chromium-63.0.3239.90

gcarq / inox-patchset

Inox patchset tries to provide a minimal Chromium based browser with focus on privacy by disabling data transmission to Google.

BSD 2-Clause "Simplified" License

364 stars 26 forks source link

Updated 0001-fix-building-without-safebrowsing.patch does not work with chromium-63.0.3239.90 #123

Closed perfect7gentleman closed 6 years ago

perfect7gentleman commented 6 years ago

subj

xsmile commented 6 years ago

@perfect7gentleman It builds fine with 095e919efd821c3e0a2d379576a74e6732a8c4d2.

@gcarq I hope you don't mind the quick update.

perfect7gentleman commented 6 years ago

i just used previous version of patch.

perfect7gentleman commented 6 years ago

updated version doesn't work too

 * Applying 0001-fix-building-without-safebrowsing.patch ...
1 out of 7 hunks FAILED -- saving rejects to file chrome/renderer/chrome_content_renderer_client.cc.rej                                                                                                                                                                                                               [ !! ]
 * ERROR: www-client/chromium-63.0.3239.90::pg_overlay failed (prepare phase):
 *   patch -p1  failed with /tmp/portage/www-client/chromium-63.0.3239.90/files/inox-patchset-63/0001-fix-building-without-safebrowsing.patch

gcarq commented 6 years ago

@xsmile Thanks a lot for the update :-) It builds fine for version 63.0.3239.84. I will do some testing and make an AUR release later today.

@perfect7gentleman Seems like it needs some adaption again for .90, but since arch linux hasn't updated chromium yet I think we should release .84 first.