search

gcarq / inox-patchset

Inox patchset tries to provide a minimal Chromium based browser with focus on privacy by disabling data transmission to Google.
BSD 2-Clause "Simplified" License
364 stars 26 forks source link

Incorrect GYP flag for disabling safe browsing #15

Closed Eloston closed 8 years ago

Eloston commented 8 years ago

@perfect7gentleman noticed that Inox still mentions safe_browsing_mode as the GYP flag to disable safe browsing (in the README and here). The flag is now called safe_browsing.

If you are going to use this flag, you will need to patch the source code to make the build work. This patch contains the modifications necessary.

perfect7gentleman commented 8 years ago

safe_browsing_mode is GN flag. also for enable_remoting is GN flag, remoting is GYP flag. https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookbook.md#Feature-flags

Eloston commented 8 years ago

Inox uses the GYP configuration system, so those flags won't work.

Eloston commented 8 years ago

29 closes this.