gcarq / inox-patchset

Inox patchset tries to provide a minimal Chromium based browser with focus on privacy by disabling data transmission to Google.
BSD 2-Clause "Simplified" License
365 stars 25 forks source link

Could you add the VA-API patch? #24

Closed HighIO closed 7 years ago

HighIO commented 8 years ago

https://aur.archlinux.org/packages/chromium-vaapi/ It is compiled with support for VA-API originally from https://raw.githubusercontent.com/saiarcot895/chromium-ubuntu-build/master/debian/patches/enable_vaapi_on_linux.diff

gcarq commented 8 years ago

Has this patch some downsides if VA-API acceleration is not available?

DragoonAethis commented 7 years ago

Status at the moment:

How about building with the VA-API patch for Intel once Chromium 55 is out? The patch should be refactored to support all drivers eventually, but it seems to be a bit more "clean", plus it's tested on x86-based Chromebooks pretty well.

forkoz commented 7 years ago

heh, I'm using chromium 56 today with FGLRX and decoding is working from this ppa: https://launchpad.net/%7Esaiarcot895/+archive/ubuntu/chromium-dev

only thing not working is native GPU memory buffers but I think that is intel only? multiple raster threads have the eat all your memory bug but single thread rendering is fine. radeontop shows heavy usage when the video is playing and comparable videos don't play in firefox without tears and stutters. FF also doesn't accelerate flash despite being the exact same flash through freshplayer.

Eloston commented 7 years ago

@forkoz

radeontop shows heavy usage when the video is playing

Do you mean CPU usage? Then it's very likely that VA-API acceleration is not working. There are some bugs reported on the GitHub repo of that PPA where the module loads successfully but it doesn't accelerate. They were also disabling the GPU sandbox.

EDIT: BTW, are you checking video acceleration status via chrome://gpu? That only tells you if it can attempt hardware acceleration, not if it is working. Also, what video are you using to test acceleration?

only thing not working is native GPU memory buffers but I think that is intel only?

There is progress on hardware-acceleated Native GPU Memory Buffers with Intel processors on Chrome OS, so that may be the only chance to get that feature on Linux. Otherwise it's not supported on any desktop OS as far as I know.

EDIT: Has anyone tried that patch out on 56 or newer and seen if it decreases CPU usage or not? Do you need to disable the GPU sandbox (or all process sandboxing) to get it to work?

DragoonAethis commented 7 years ago

@Eloston radeontop measures GPU usage. Also, 57/58 is right about the corner, and the related patch in that PPA was updated for 58 recently (see History for 57), so it might be worth migrating to a newer version first.

xsmile commented 7 years ago

Looks like chromium will support VA-API without modifications soon: http://www.phoronix.com/scan.php?page=news_item&px=Chrome-VA-API-Nears

EDIT: If using the patch from https://chromium-review.googlesource.com/c/532294/, VA-API usage is disabled by default and can be toggled in chrome://flags. In case the required libva library is missing, Chromium falls back to software decoding. It should be safe to include the patch now.

DragoonAethis commented 7 years ago

As of 61, VA-API support is included and seems to be working fine on Intel GPUs. This can be closed.