search

gcarq / inox-patchset

Inox patchset tries to provide a minimal Chromium based browser with focus on privacy by disabling data transmission to Google.
BSD 2-Clause "Simplified" License
365 stars 25 forks source link

Question about fieldtrial_testing_like_official_build=false #41

Closed Eloston closed 7 years ago

Eloston commented 7 years ago

I noticed in your PKGBUILD file here that you specified fieldtrial_testing_like_official_build=false.

However on line 270 of build/config/BUILD.gn:

  if (!fieldtrial_testing_like_official_build && !is_chrome_branded) {
    defines += [ "FIELDTRIAL_TESTING_ENABLED" ]
  }

Also notice in build/config/features.gni:

  # Set to true make a build that disables activation of field trial tests
  # specified in testing/variations/fieldtrial_testing_config_*.json.
  # Note: this setting is ignored if is_chrome_branded.
  fieldtrial_testing_like_official_build = is_chrome_branded

Since you're not chrome branded, does that mean you want to turn fieldtrial testing on? What's the benefit of enabling fieldtrial testing?

gcarq commented 7 years ago

My intention was to disable fieldtrial_testing_like_official_build because it's not needed in a chromium build, but as you pointed out that seems not quite true. IMO there is no reason for an open source project to force users to use fieldtrial A+B tests. Some time ago I found a blog entry describing up and downs of field trial tests.

Eloston commented 7 years ago

I've also disabled fieldtrial testing in ungoogled-chromium. It's interesting that they enable fieldtrial testing in Chromium and not Chrome.