String resources, npes, declaration/casting redundancies refactor

gcash / android-neutrino

Android mobile wallet using the bchwallet/neutrino backend

9 stars 9 forks source link

String resources, npes, declaration/casting redundancies refactor #25

Closed gubatron closed 5 years ago

gubatron commented 5 years ago

Silenced some trivial NPE warnings
Removed redundant casts and initializations, and respective import cleanups
Trivial lambda refactors

gubatron commented 5 years ago

The final goal with the string resource stuff is to be able to translate the app easily to multiple languages.

gubatron commented 5 years ago

All String resources in MainActivity, SendActivity, ReceiveActivity extracted.

Also performed a lot of minor cleanups and a bunch of NPE warnings have been taken care of, along with several others related to missuse of switch statements, boolean simplifications, anonymous classes turned into lambda expressions, same variable assignment, unused variables cleaned up, import cleanups.

Broke fixes into individual commits for easier reviewing / cherry-picking.

zquestz commented 5 years ago

This looks great, however will wait for Java folks to chime in. My Java foo needs work. =)