gcash / android-neutrino

Android mobile wallet using the bchwallet/neutrino backend
9 stars 9 forks source link

Improve view usability for small screened devices #31

Closed zquestz closed 4 years ago

zquestz commented 5 years ago

This fixes a bunch of issues in Neutrino for smaller screens. I tested these changes on 2 different emulators:

Larger screen -> Pixel 2 (1080x1920) 5 inch display Smaller screen -> Nexus One (480x800) 3.7 inch display

I had to remove a little of the text from the backup flow. If we shrink the font it is illegible on larger screens, if we keep it, then the text flows off the bottom of the screen and they can't read it on small phones.

I would suggest testing it out in a similar setup. Some of the screens do look a bit different on a larger phone, but I think it is worth it for increased compatibility.

cpacia commented 4 years ago

So I think I'd like to see if we can find a way to fix these views for small screens in a way that doesn't interfere with the large screen look. As it stands I think the difference between this and what the screen large screen looks like without this PR is enough to warrant investigating other way of implementing this change.

zquestz commented 4 years ago

Just to be clear, the only change you consider a blocker are the pin pad changes? I will look into another way to do this.

zquestz commented 4 years ago

Closing. Will reopen with cleaned up version when ready.