search

gcash / bchwallet

A secure bitcoin cash wallet daemon written in Go (golang)
ISC License
43 stars 29 forks source link

Replace hex seed with bip39 mnemonic #5

Closed cpacia closed 6 years ago

tyler-smith commented 6 years ago

This makes the generated seed have half as many bits. I assume you changed that so that the mnemonic will be 12 words instead of 24?

I think defaulting to 256 bits would be better, but other than that this change looks correct.

cpacia commented 6 years ago

I've always used 128 in the past just because it's shorter. 128 should still be well out of brute force range.