gcash / bchwallet

A secure bitcoin cash wallet daemon written in Go (golang)
ISC License
43 stars 29 forks source link

Consider tagging module "walletdb"? #79

Open Rick-xuy opened 1 year ago

Rick-xuy commented 1 year ago

I found that some packages, say github.com/gcash/bchwallet/walletdb, are placed in submodule github.com/gcash/bchwallet/walletdb instead of root module.
However, it seems that submodule github.com/gcash/bchwallet/walletdb is not tagged. According to go docs, submodule should be tagged like relative-path-to-root/vX.X.X. At now, when trying to import package github.com/gcash/bchwallet/walletdb, downstream would depends on pseudo-version of module github.com/gcash/bchwallet/walletdb.

github.com/gcash/bchwallet/walletdb v0.0.0-20210524044131-61bcca2ae6f9

I think it is not very readable and difficult to upgrade. This is not conductive to version control either. So, I propose whether it is possible to tag submodule properly. For example, walletdb/v0.0.1, walletdb/v0.10.0etc, so that other project can use tag to import this module in go.mod.