This is good in all cases and as send_command_ack takes named-parameter is easy to achieve.
But it will be mandatory if we reorder the parameter of send_command_ack function (I made a branch where I do so because I make protocol optional and I prefer to keep the mandatory parameter before the optional one thus protocol became the second parameter instead of the first.
Aohzan
commented
1 year ago
This is good in all cases and as send_command_ack takes named-parameter is easy to achieve.
But it will be mandatory if we reorder the parameter of send_command_ack function (I made a branch where I do so because I make protocol optional and I prefer to keep the mandatory parameter before the optional one thus protocol became the second parameter instead of the first.