feat: quick and dirty refactoring to support properly oregon sensors

gce-electronics / HA_RFPlayer

RFPlayer plugin for Home assistant

Apache License 2.0

29 stars 10 forks source link

feat: quick and dirty refactoring to support properly oregon sensors #47

Closed racletteparty closed 3 months ago

racletteparty commented 4 months ago

fix infinite loop while setting up discovered devices

prahal commented 2 months ago

Is it expected that this PR " feat: quick and dirty refactoring to support properly oregon sensors #47" was only merged in branches that are no more? It is not merged in main.

I get an infinite loop while adding Chacon Switch via send_command. Should this PR fix it?

Aohzan commented 2 months ago

it is not merged as @racletteparty closed this PR

You can try this branch racletteparty:feature/fix to check if it resolves your issue, if yes we will reopen this PR

prahal commented 2 months ago

@racletteparty could you point to the part of this PR that is about fixing the infinite loop? There are a lot of unrelated fixes in this PR. I already pushed a few minor ones in specific PR.

I might have to diagnose the infinite loop anew otherwise.