search

gcfavorites / fxif

Automatically exported from code.google.com/p/fxif
0 stars 0 forks source link

Bad regexp in visibilityOfMenuItems #18

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
fxif.js has this regexp:

        var reg_jpg = new RegExp('\.jp(eg|e|g)(\\?.*)?$', 'i');
        if (reg_jpg.test(imgURL) || isJPEG(imgURL)) {

That \. is the same as a . and will match any character.  A /regexp/i form 
wouldn't require double-backslashing.

Original issue reported on code.google.com by ivan@ludios.org on 12 Oct 2012 at 12:26

GoogleCodeExporter commented 9 years ago

Original comment by cueyr...@gmail.com on 1 Apr 2013 at 5:10

GoogleCodeExporter commented 9 years ago 
This has already been fixed in FxIF 0.4.6.

Original comment by cueyr...@gmail.com on 20 Apr 2013 at 6:45