search

gchq / CyberChef

The Cyber Swiss Army Knife - a web app for encryption, encoding, compression and data analysis
https://gchq.github.io/CyberChef
Apache License 2.0
29.3k stars 3.28k forks source link

Added 2 new operations 'NTPTimestampToUNIXTimestamp' and 'UNIXTimesta… #1814

Open KossiJunior opened 6 months ago

KossiJunior commented 6 months ago

Hello,

I'm adding 2 new operations to convert NTP timestamp to UNIX timestamp and the other way round. The NTP timestamp is detailed in the following links :

https://www.ntp.org/reflib/y2k/ https://datatracker.ietf.org/doc/html/rfc5905 https://tickelton.gitlab.io/articles/ntp-timestamps/

KossiJunior commented 6 months ago

Failed on UI tests. Can you fix it or do i need to made modifications to the operations code ?

KossiJunior commented 5 months ago

Hello,

Any news on this ?

a3957273 commented 5 months ago

Hey @KossiJunior, this is a really good PR and a nice addition to CyberChef! Could you add the tests you've created to the test runner in this file:

https://github.com/gchq/CyberChef/blob/master/tests/operations/index.mjs

Other than that, your PR looks ready to go!

KossiJunior commented 5 months ago

It should be good.