gchq / CyberChef

The Cyber Swiss Army Knife - a web app for encryption, encoding, compression and data analysis
https://gchq.github.io/CyberChef
Apache License 2.0
29.41k stars 3.29k forks source link

[Feature] Change to nginx-unprivileged image for better kubernetes support #1922

Open hsolberg opened 1 month ago

hsolberg commented 1 month ago

Solves https://github.com/gchq/CyberChef/issues/1880

Not sure which image-repo you prefer to use, it's using Docker Hub in the pull-request (should be fine since its from a "Verified Publisher" and thus does not count towards the rate limit).

Alternative sources can be found here Amazon ECR - https://gallery.ecr.aws/nginx/nginx-unprivileged Docker Hub - https://hub.docker.com/r/nginxinc/nginx-unprivileged GitHub Container Registry - https://github.com/nginxinc/docker-nginx-unprivileged/pkgs/container/nginx-unprivileged Quay - https://quay.io/repository/nginx/nginx-unprivileged

hsolberg commented 1 month ago
Originally encountered a problem with the ChromeDriver version that's been addressed in d3adfc7 , expand to show the context if needed. UI Test fails with the error below. Seems a lot of pull-requests are facing the same issue. ``` >> - Starting ChromeDriver on port 9515... >> Error >> Response 500 POST /session (28155ms) { value: { error: 'session not created', message: 'session not created: This version of ChromeDriver only supports Chrome version 127\n' + 'Current browser version is 129.0.6668.58 with binary path /opt/google/chrome/chrome', stacktrace: '' } } >> Error ```
Kaurin commented 1 month ago

Have these tests been fixed?

hsolberg commented 1 month ago

Have these tests been fixed?

Seem to work now after rebasing. Looks like this commit addressed the issue -> https://github.com/gchq/CyberChef/commit/d3adfc7c3e5719279524356bce5261bd8350c0f8

Kaurin commented 1 month ago

You might want to change the docker commandline in the readme so it shows forwarding to the new default ports of 8080 instead of the previous 80:

docker run -it -p 8080:8080 cyberchef

and

docker run -it -p 8080:8080 ghcr.io/gchq/cyberchef:latest

As per: https://hub.docker.com/r/nginxinc/nginx-unprivileged