search

gchq / Gaffer

A large-scale entity and relation database supporting aggregation of properties
Apache License 2.0
1.77k stars 353 forks source link

Fix SplitStoreFromRDD tests timing out #2525

Closed t92549 closed 3 years ago

t92549 commented 3 years ago

The tests frequently time out on the GitHub Actions runners and fail the test due to a full AccumuloStore being created rather than a MiniAccumuloStore: https://github.com/gchq/Gaffer/blob/e8cede87dfeec613b5260a0ad02aec1c9aba8b66/library/spark/spark-accumulo-library/src/test/java/uk/gov/gchq/gaffer/sparkaccumulo/integration/operation/handler/javaardd/SplitStoreFromJavaRDDOfElementsHandlerIT.java#L154

See example of failed test run: https://github.com/gchq/Gaffer/pull/2523/checks?check_run_id=3951156261

This effects SplitStoreFromJavaRDDOfElementsHandlerIT and SplitStoreFromRDDOfElementsHandlerIT

t92549 commented 3 years ago

It should be said this is the root cause of the prior issue https://github.com/gchq/Gaffer/issues/2505. This was fixed by reverting to JUnit 4, but that was not the actual problem so that test should be fixed and put back as JUnit 5.

n3101 commented 3 years ago

It should be said this is the root cause of the prior issue #2505. This was fixed by reverting to JUnit 4, but that was not the actual problem so that test should be fixed and put back as JUnit 5.

Good spot!