Closed tb06904 closed 2 months ago
Attention: Patch coverage is 72.50000%
with 11 lines
in your changes are missing coverage. Please review.
Project coverage is 66.70%. Comparing base (
1836a6f
) to head (a8e9fde
).
Files | Patch % | Lines |
---|---|---|
...a/uk/gov/gchq/gaffer/commonutil/otel/OtelUtil.java | 0.00% | 10 Missing :warning: |
...ain/java/uk/gov/gchq/gaffer/graph/GraphConfig.java | 87.50% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Adds a basic implementation of Open Telemetry that will record Spans across executions of Operations/OperationChains. Can be toggled on via a
otelActive
option in thegraphConfig.json
(off by default). Hopefully is a useful start point to be expanded on if required.Is difficult one to demonstrate via unit testing but been manually tested to ensure Spans look useful with relevant data via a
Jaeger
UI. Uses the auto configure feature of Open Telemetry so can be easily configured where and how to export data to via environment variables e.g.OTEL_SERVICE_NAME=gaffer-rest
- sets the service name togaffer-rest
OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://jaeger:4317
- sets the endpoint to export traces to e.g.Jaeger
OTEL_TRACES_EXPORTER=console
- sets the exporter to console rather than the default of OTEL (needs to be OTEL to work with Jaeger).Related issue