Closed tb06904 closed 5 months ago
Attention: Patch coverage is 77.27273%
with 25 lines
in your changes are missing coverage. Please review.
Project coverage is 66.76%. Comparing base (
40ef69b
) to head (bd35f37
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Given the ability to set the user provided in this PR, to what extent does this resolve #2991?
See comment added to #2991
Adds the ability to override a limited set of graph variables when doing a gremlin query. This utilises the
with()
feature of gremlin that will attach aOptionsStrategy
to the query that can then be parsed for the relevant options passed in.To implement this it required creating a custom traversal mechanism for gremlin
GraphStep
s so that we can override and parse the options on the query. Adding this step also allowed for a small optimisation to ensure anyhasLabel
type queries on the originalGraphStep
are parsed to create a representative GafferView
. The intention is that additional custom traversal steps are added in future to optimise the mapping of gremlin to standard Gaffer operations.As an example this allows the following:
Related issue