gchq / Gaffer

A large-scale entity and relation database supporting aggregation of properties
Apache License 2.0
1.75k stars 354 forks source link

Gh-3210: Fix GafferPopVertex.properties() output #3211

Closed p29876 closed 1 month ago

p29876 commented 1 month ago

Set a proper ID for GafferPopVertexProperties so that equals and hashCode work as expected simplify GafferPopVertex.properties() method add unit test to catch error

Related issue

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.85%. Comparing base (759531c) to head (bcf5dce).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3211 +/- ## ============================================= - Coverage 66.85% 66.85% -0.01% Complexity 2555 2555 ============================================= Files 912 912 Lines 29284 29276 -8 Branches 3268 3265 -3 ============================================= - Hits 19578 19572 -6 + Misses 8259 8258 -1 + Partials 1447 1446 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.