search

gchq / Gaffer

A large-scale entity and relation database supporting aggregation of properties
Apache License 2.0
1.75k stars 354 forks source link

Gh-3209: GetAll Limit fails on Proxy Store #3214

Closed tb06904 closed 1 month ago

tb06904 commented 1 month ago

Fixes most of the issues in the original issue, two minor fixes:

  1. ensures the correct method is called in the GafferPopGraphStep
  2. Prevents null operation chain options.

Added work around to main serialisation error in the proxy store so that it attempts to deserialise element iterators. This will be fixed in a larger rework of the proxy store so that it does not need to double deserialise.

Related issue

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.87%. Comparing base (9d2caa8) to head (3bf5600).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3214 +/- ## ========================================== Coverage 66.86% 66.87% - Complexity 2557 2558 +1 ========================================== Files 912 912 Lines 29276 29287 +11 Branches 3265 3266 +1 ========================================== + Hits 19576 19586 +10 Misses 8256 8256 - Partials 1444 1445 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.