Open p29876 opened 3 weeks ago
Attention: Patch coverage is 80.31496%
with 25 lines
in your changes missing coverage. Please review.
Project coverage is 67.15%. Comparing base (
4520b25
) to head (39fbfe9
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Quality Gate failed
Failed conditions
3.8% Duplication on New Code (required ≤ 3%)
I think the duplication is largely due to a wider issue where many of the core classes used here are interfaces which expect class instance variables in the implementing classes. This results in all implementing classes creating the same variables and method overrides, one way to fix this would be to use abstract classes where appropriate instead but it is a larger problem to fix.
Failed conditions
3.8% Duplication on New Code (required ≤ 3%)
Related issue