gchq / Gaffer

A large-scale entity and relation database supporting aggregation of properties
Apache License 2.0
1.75k stars 354 forks source link

Gh-3237 Implement DeleteElements for Map Store #3239

Open p29876 opened 3 weeks ago

p29876 commented 3 weeks ago

Related issue

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 80.31496% with 25 lines in your changes missing coverage. Please review.

Project coverage is 67.15%. Comparing base (4520b25) to head (39fbfe9).

Files Patch % Lines
...q/gaffer/operation/impl/delete/DeleteElements.java 76.08% 11 Missing :warning:
.../uk/gov/gchq/gaffer/commonutil/stream/Streams.java 0.00% 8 Missing :warning:
...hq/gaffer/mapstore/impl/DeleteElementsHandler.java 91.22% 0 Missing and 5 partials :warning:
...java/uk/gov/gchq/gaffer/proxystore/ProxyStore.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3239 +/- ## ============================================= + Coverage 67.07% 67.15% +0.07% - Complexity 2558 2569 +11 ============================================= Files 919 921 +2 Lines 29492 29619 +127 Branches 3288 3296 +8 ============================================= + Hits 19782 19890 +108 - Misses 8261 8277 +16 - Partials 1449 1452 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tb06904 commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions 3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

I think the duplication is largely due to a wider issue where many of the core classes used here are interfaces which expect class instance variables in the implementing classes. This results in all implementing classes creating the same variables and method overrides, one way to fix this would be to use abstract classes where appropriate instead but it is a larger problem to fix.

sonarcloud[bot] commented 3 days ago

Quality Gate Failed Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud