gchq / Gaffer

A large-scale entity and relation database supporting aggregation of properties
Apache License 2.0
1.77k stars 350 forks source link

Gh-3303: No error reported when Gremlin endpoint fails #3304

Closed tb06904 closed 5 days ago

tb06904 commented 1 week ago

Fixes the issue where the status was always reported as 200 on the Gremlin execute endpoints. They now fail with 500 and a message.

Some misc fixes for open telemetry spans as well.

Related issue

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.84%. Comparing base (5960ac1) to head (d26074d). Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...store/operation/handler/OperationChainHandler.java 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3304 +/- ## ========================================== Coverage 67.83% 67.84% Complexity 2595 2595 ========================================== Files 951 951 Lines 30337 30352 +15 Branches 3342 3343 +1 ========================================== + Hits 20580 20593 +13 - Misses 8291 8292 +1 - Partials 1466 1467 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud