gchq / Gaffer

A large-scale entity and relation database supporting aggregation of properties
Apache License 2.0
1.77k stars 350 forks source link

Move classes from spark-accumulo-library that are not specific to Accumulo to spark-library #677

Closed gaffer01 closed 7 years ago

gaffer01 commented 7 years ago

There are some classes in spark-accumulo-library which are not specific to Accumulo. These should be moved to spark-library. The unit test FilterToOperationConverterTest should be changed so that it tests that the correct operations are created, rather than testing that those operations give the correct results when applied to an AccumuloStore. This will allow that unit test to also be moved to spark-library.

There should be unit tests for the various converters, e.g. FreqMapConverter. We should also create converters for the Union sketch from DataSketches.

p013570 commented 7 years ago

Merged into develop.