search

gchq / coreax

A library for coreset algorithms, written in Jax for fast execution and GPU support.
Apache License 2.0
25 stars 2 forks source link

Create Weights classes #158

Closed tp832944 closed 11 months ago

tp832944 commented 1 year ago

See #105 for OOP design.

tp832944 commented 1 year ago

How it feeds into DataReduction class is not yet clear. Await finalisation of design.

bk958178 commented 12 months ago

@tl82649 In the OOP design (see https://github.com/gchq/coreax/issues/105#issuecomment-1766799165), the WeightsOptimiser class contains the methods solve and solve_approximate.

Is solve_approximate implemented in the pre-OOPed code?

tl82649 commented 12 months ago

@bk958178 It isn't. We only solve the linear system with solve. solve_approximate is an intent to implement fast weight approximation methods that don't require solving a full linear system, e.g. this paper