search

gchq / coreax

A library for coreset algorithms, written in Jax for fast execution and GPU support.
Apache License 2.0
25 stars 2 forks source link

Create DataReduction ABC and reduction strategies #159

Closed tp832944 closed 9 months ago

tp832944 commented 1 year ago

See #105 for OOP design.

tp832944 commented 1 year ago

@sk062380 I've started a discussion at https://github.com/gchq/coreax/issues/105#issuecomment-1781397519 regarding the meaning of weighted.

tp832944 commented 12 months ago

@sk062380 New OOP diagram at https://github.com/gchq/coreax/issues/105#issuecomment-1785468607. weighted in DataReduction is now weights and takes something to be passed to weights_factory: string or WeightsOptimiser.

tp832944 commented 10 months ago

DataReduction/Coreset is provisionally ready for review.

tp832944 commented 10 months ago

In MapReduce, I have removed the calculation of weights. If required, the user can call Coreset.solve_weights.