search

gchq / gaffer-docker

Gaffer Docker images and associated Helm charts for deploying on Kubernetes
https://gchq.github.io/gaffer-docker
Apache License 2.0
30 stars 36 forks source link

Allow for building Dockerfiles from develop branch of Gaffer #356

Open GCHQDeveloper314 opened 2 months ago

GCHQDeveloper314 commented 2 months ago

It would be good to support building images directly from the develop branch of Gaffer. Originally posted by @GCHQDeveloper314 in https://github.com/gchq/gaffer-docker/issues/325#issuecomment-1704992927

This isn't possible because the GAFFER_VERSION ARG needs to be both a valid Gaffer version (for copying JAR files) and also a branch name.

https://github.com/gchq/gaffer-docker/blob/f13bb50e56e6faa236688bea4bf6401f2966eeb2/docker/gaffer/Dockerfile#L49

https://github.com/gchq/gaffer-docker/blob/f13bb50e56e6faa236688bea4bf6401f2966eeb2/docker/gaffer/Dockerfile#L53

tb06904 commented 2 days ago

There is an alternative to this where instead we could use Maven to download the Gaffer JARs and copy them into the image (how the current gaffer-gremlin image does it). This technically allows develop building as you can clone and locally build Gaffer as a snapshot which will be available in the local Maven repo so could be specified as a version for copying into the image.