gchq / gaffer-experimental

Apache License 2.0
6 stars 7 forks source link

Swap GafferBuilder classes for Helm Value.yaml overrides as configs #107

Closed macenturalxl1 closed 3 years ago

macenturalxl1 commented 3 years ago

As a User: I want to add my own Value.yaml overrides So that: I can configure my own pre configured custom helm deployments

Deliverable:

Additional Info: Example .yaml override file names and configs will look like these:

rocky341 commented 3 years ago

Hi @r32575, Currently working on this ticket and have come across an issue to do with schemas. As there is no logic in the API when creating a spec it always adds a schema to the spec. This schema may be empty in for example a federated store however it is still added. E.g:

spec:

As opposed to:

spec:

Is this an issue or is it okay to include an empty schema in things such as federated stores?

t92549 commented 3 years ago

@rocky341 Yes this is fine as federated stores have an empty schema