gchq / gaffer-experimental

Apache License 2.0
6 stars 7 forks source link

Sidecar fixes #302

Closed rocky341 closed 2 years ago

rocky341 commented 2 years ago

Hi @t92549 @GCHQDeveloper314

Some small fixes which are needed in order for the sidecars to work without issue

codecov-commenter commented 2 years ago

Codecov Report

Merging #302 (886d61b) into master (1c9edbc) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #302   +/-   ##
=========================================
  Coverage     83.97%   83.97%           
  Complexity      246      246           
=========================================
  Files           119      119           
  Lines          2764     2764           
  Branches        371      371           
=========================================
  Hits           2321     2321           
  Misses          402      402           
  Partials         41       41           
Flag Coverage Δ
unittests 68.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...v/gchq/gaffer/gaas/handlers/DeploymentHandler.java 45.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c9edbc...886d61b. Read the comment docs.