search

gchq / gaffer-experimental

Apache License 2.0
6 stars 7 forks source link

Gh 293 improve gaa s security logging #303

Closed go159lab closed 2 years ago

go159lab commented 2 years ago

Improve logging to capture high-level actions on the system.

codecov-commenter commented 2 years ago

Codecov Report

Merging #303 (6f07554) into master (14b0eda) will increase coverage by 0.12%. The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master     #303      +/-   ##
============================================
+ Coverage     83.58%   83.71%   +0.12%     
- Complexity      253      264      +11     
============================================
  Files           121      124       +3     
  Lines          2821     2978     +157     
  Branches        373      370       -3     
============================================
+ Hits           2358     2493     +135     
- Misses          419      440      +21     
- Partials         44       45       +1
Flag Coverage Δ
unittests 69.09% <75.00%> (+0.88%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gaffer/gaas/factories/KubernetesObjectFactory.java 91.48% <20.00%> (-1.92%) :arrow_down:
...v/gchq/gaffer/gaas/handlers/DeploymentHandler.java 45.11% <25.00%> (-0.35%) :arrow_down:
.../gchq/gaffer/gaas/services/DeleteGraphService.java 20.00% <50.00%> (+20.00%) :arrow_up:
...gchq/gaffer/gaas/sidecar/services/AuthService.java 58.33% <60.00%> (+1.19%) :arrow_up:
...a/uk/gov/gchq/gaffer/gaas/client/GafferClient.java 75.86% <60.00%> (ø)
...affer/gaas/factories/GaaSRestExceptionFactory.java 68.18% <66.66%> (-0.24%) :arrow_down:
...gchq/gaffer/gaas/util/GafferSpecConfigsLoader.java 84.37% <66.66%> (-1.84%) :arrow_down:
...affer/gaas/sidecar/auth/JwtUserDetailsService.java 100.00% <100.00%> (ø)
...q/gaffer/gaas/sidecar/controller/CustomFilter.java 76.74% <100.00%> (+4.52%) :arrow_up:
...fer/gaas/sidecar/controller/SidecarController.java 100.00% <100.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14b0eda...6f07554. Read the comment docs.

go159lab commented 2 years ago

@t92549 I made the changes needed for using parameterization logging