search

gchq / gaffer-experimental

Apache License 2.0
6 stars 7 forks source link

Gh 306 /what-auth endpoint #307

Closed rocky341 closed 2 years ago

rocky341 commented 2 years ago

Hi @t92549 @GCHQDeveloper314

This PR links to ticket #306

It provides an extra endpoint to the sidecars which enable the dynamic UI (which will be introduced in a separate PR) to function.

There is one model between the 2 which are identical - WhatAuthResponse - which could be moved into a common location such as rest/util or rest/model but I'm not sure if we want to introduce rest as a dependency on the sidecars so currently I have left WhatAuthResponse as a model in BOTH sidecars. Let me know if you want this to be moved into a shared location such as those I've mentioned.

codecov-commenter commented 2 years ago

Codecov Report

Merging #307 (666f5d1) into master (f4e900f) will decrease coverage by 0.27%. The diff coverage is 69.23%.

@@             Coverage Diff              @@
##             master     #307      +/-   ##
============================================
- Coverage     83.97%   83.69%   -0.28%     
- Complexity      246      257      +11     
============================================
  Files           119      121       +2     
  Lines          2764     2815      +51     
  Branches        371      372       +1     
============================================
+ Hits           2321     2356      +35     
- Misses          402      416      +14     
- Partials         41       43       +2
Flag Coverage Δ
unittests 68.42% <69.23%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...q/gaffer/gaas/sidecar/controller/CustomFilter.java 70.58% <0.00%> (-2.95%) :arrow_down:
...q/gaffer/gaas/sidecar/controller/CustomFilter.java 80.00% <0.00%> (-20.00%) :arrow_down:
...q/gaffer/gaas/sidecar/models/WhatAuthResponse.java 57.14% <57.14%> (ø)
...q/gaffer/gaas/sidecar/models/WhatAuthResponse.java 57.14% <57.14%> (ø)
...fer/gaas/sidecar/controller/SidecarController.java 100.00% <100.00%> (ø)
...fer/gaas/sidecar/controller/SidecarController.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4e900f...666f5d1. Read the comment docs.