search

gchq / gaffer-experimental

Apache License 2.0
6 stars 7 forks source link

Gh 292 gaas UI dynamic #308

Closed rocky341 closed 2 years ago

rocky341 commented 2 years ago

Hi @t92549 @GCHQDeveloper314

This PR introduces the dynamic UI. This means that no additional configuration is required when using different sidecars. The UI is dynamic based on the response it receives from the /what-auth endpoint which is found in the sidecars.

292

codecov-commenter commented 2 years ago

Codecov Report

Merging #308 (59c6d27) into master (14b0eda) will increase coverage by 0.08%. The diff coverage is 87.67%.

@@             Coverage Diff              @@
##             master     #308      +/-   ##
============================================
+ Coverage     83.58%   83.67%   +0.08%     
  Complexity      253      253              
============================================
  Files           121      124       +3     
  Lines          2821     2922     +101     
  Branches        373      369       -4     
============================================
+ Hits           2358     2445      +87     
- Misses          419      432      +13     
- Partials         44       45       +1
Flag Coverage Δ
unittests 68.17% <50.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/cluster-namespaces/cluster-namespaces.tsx 100.00% <ø> (ø)
...as-ui/src/components/create-graph/create-graph.tsx 90.29% <ø> (ø)
...ervice/gaas-ui/src/components/login/login-form.tsx 81.39% <ø> (-0.83%) :arrow_down:
.../src/components/login/temp-password-login-form.tsx 73.91% <ø> (-1.09%) :arrow_down:
...gaas-ui/src/components/view-graphs/view-graphs.tsx 100.00% <ø> (ø)
...ervice/gaas-ui/src/rest/clients/auth-api-client.ts 33.33% <0.00%> (ø)
...tion/CustomizedResponseEntityExceptionHandler.java 72.22% <50.00%> (-2.78%) :arrow_down:
...rvice/gaas-ui/src/components/login/login-modal.tsx 84.61% <83.33%> (-5.67%) :arrow_down:
...ce/gaas-ui/src/rest/clients/auth-sidecar-client.ts 86.66% <86.66%> (ø)
...rc/components/navigation-bar/navigation-appbar.tsx 92.18% <89.28%> (+0.35%) :arrow_up:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14b0eda...59c6d27. Read the comment docs.

rocky341 commented 2 years ago

I'm seeing "GitHub Actions run-ui-code-analysis" warnings in:

  • gaas-ui/src/components/login/dynamic-login-form.tsx
  • gaas-ui/src/components/navigation-bar/navigation-appbar.tsx
  • gaas-ui/src/rest/clients/auth-sidecar-client.ts

A separate PR is being raised which addresses warnings/does other UI clean up so this should be resolved in that PR

rocky341 commented 2 years ago

PR

I'm seeing "GitHub Actions run-ui-code-analysis" warnings in:

  • gaas-ui/src/components/login/dynamic-login-form.tsx
  • gaas-ui/src/components/navigation-bar/navigation-appbar.tsx
  • gaas-ui/src/rest/clients/auth-sidecar-client.ts

A separate PR is being raised which addresses warnings/does other UI clean up so this should be resolved in that PR

PR is #313

t92549 commented 2 years ago

Looks good aside from the warnings

Never mind

t92549 commented 2 years ago

Sorry, merging https://github.com/gchq/gaffer-experimental/pull/304 broke this

rocky341 commented 2 years ago

@t92549 @GCHQDeveloper314

Conflicts have been resolved