search

gchq / gaffer-experimental

Apache License 2.0
6 stars 7 forks source link

Gh 323 sidecar logging #324

Closed rocky341 closed 2 years ago

rocky341 commented 2 years ago

Hi @t92549 @GCHQDeveloper314 This PR adds log4j.xml configuration to the sidecars

323

rocky341 commented 2 years ago

Looks ok, except that there's a checkstyle error: Unused import - org.apache.log4j.BasicConfigurator

Ah yes sorry forgot to remove the import. Should be resolved now.

codecov-commenter commented 2 years ago

Codecov Report

Merging #324 (47cae07) into master (5d32539) will increase coverage by 0.02%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #324      +/-   ##
============================================
+ Coverage     84.33%   84.36%   +0.02%     
  Complexity      283      283              
============================================
  Files           123      123              
  Lines          3014     3013       -1     
  Branches        380      380              
============================================
  Hits           2542     2542              
+ Misses          426      425       -1     
  Partials         46       46
Flag Coverage Δ
unittests 71.03% <ø> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...v/gchq/gaffer/gaas/sidecar/SidecarApplication.java 33.33% <ø> (+8.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d32539...47cae07. Read the comment docs.