search

gchq / gaffer-experimental

Apache License 2.0
6 stars 7 forks source link

Gh 327 event logging #334

Closed rocky341 closed 2 years ago

rocky341 commented 2 years ago

327

Introduces event logging with admins able to access a h2 console in order to see event logs.

Logs are persistent

codecov-commenter commented 2 years ago

Codecov Report

Merging #334 (cb3ddaa) into master (5962e14) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #334      +/-   ##
============================================
+ Coverage     84.47%   84.50%   +0.03%     
  Complexity      314      314              
============================================
  Files           130      130              
  Lines          3195     3202       +7     
  Branches        393      393              
============================================
+ Hits           2699     2706       +7     
  Misses          444      444              
  Partials         52       52
Flag Coverage Δ
unittests 72.22% <100.00%> (+0.15%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...v/gchq/gaffer/gaas/controller/GraphController.java 83.87% <100.00%> (+2.05%) :arrow_up:
...c/components/add-collaborator/add-collaborator.tsx 94.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5962e14...cb3ddaa. Read the comment docs.

rocky341 commented 2 years ago

Looking into why semgrep is failing on the pipeline

rocky341 commented 2 years ago

@t92549 @GCHQDeveloper314

Fixed the semgrep issue looks like Semgrep received an update which changed the way things work a bit. Semgrep now needs its own yaml file and I have updated the settings to run and then upload findings to the security dashboard. The positive of this move is that for false positives such as the middleware.js error, which kept breaking the pipeline, can now be dismissed as a false positive however is still documented in the security dashboard.

rocky341 commented 2 years ago

@t92549 @GCHQDeveloper314

Ready for review