search

gchq / gaffer-experimental

Apache License 2.0
6 stars 7 forks source link

UI - When creating a proxy from URL input retrieve graphID and description from that graph #76

Closed rocky341 closed 3 years ago

rocky341 commented 3 years ago

As a user when I input a URL to add to the federated store I want to see the graphId and description of that graph in the table below so I know its the correct graph.

t92549 commented 3 years ago

Retrieving the graphId is dependent on a new feature that hasn't been merged yet, described here: https://github.com/gchq/Gaffer/issues/2411. Retrieving the description can be done by using the /graph/config/description end point.

t92549 commented 3 years ago

https://github.com/gchq/Gaffer/pull/2412 has been merged so you should now be able to see a /graph/config/graphId endpoint also.

t92549 commented 3 years ago

This is useful not only for clarity in the graph table, but when the request is made to the API to make the federated store. In this case, the same graphId and description from the endpoint should be passed as the proxy graphId and description.

t92549 commented 3 years ago

The latest Gaffer image on dockerhub should now have the /graph/config/graphId endpoint implemented in gchq/Gaffer#2412

rocky341 commented 3 years ago

Hi @t92549 , Taking a look at this ticket now and can't find the endpoint in spring rest API. I think you've added it to core rest API although we use spring rest API. Would it be possible for you to make the same changes you made in core in rest as well? Thanks

t92549 commented 3 years ago

Hi @t92549 , Taking a look at this ticket now and can't find the endpoint in spring rest API. I think you've added it to core rest API although we use spring rest API. Would it be possible for you to make the same changes you made in core in rest as well? Thanks

Apologies @rocky341, will add it under this ticket https://github.com/gchq/Gaffer/issues/2430. Cheers for pointing that out.

rocky341 commented 3 years ago

@t92549 I see the ticket https://github.com/gchq/Gaffer/issues/2430 has been closed now. Does this mean the endpoint is now available in spring rest API?

t92549 commented 3 years ago

@rocky341 It is and should be available in the newly release 1.17.0

rocky341 commented 3 years ago

@t92549 okay perfect thank you