Closed t92549 closed 3 years ago
I think perhaps not overwriting requests' default headers and instead adding to them might make more sense:
https://github.com/gchq/gaffer-tools/blob/cc6d0439ce068142e201e8a48ed4756e0d49de63/python-shell/src/gafferpy/gaffer_connector_requests.py#L49-L50
This currently only happens when headers are provided to the GafferConnector constructor. The requests default headers add useful user agent information, and if someone really wanted to hide that they could just set conn._session.headers = None
conn._session.headers = None
I think perhaps not overwriting requests' default headers and instead adding to them might make more sense:
https://github.com/gchq/gaffer-tools/blob/cc6d0439ce068142e201e8a48ed4756e0d49de63/python-shell/src/gafferpy/gaffer_connector_requests.py#L49-L50
This currently only happens when headers are provided to the GafferConnector constructor. The requests default headers add useful user agent information, and if someone really wanted to hide that they could just set
conn._session.headers = None