gchq / gaffer-tools

gaffer-tools is deprecated. Use https://github.com/gchq/gafferpy instead
Apache License 2.0
50 stars 29 forks source link

gh-927: Provided mechanism for users to override seed types when using the UI #928

Closed t511203 closed 3 years ago

t511203 commented 3 years ago

Notes:

Related Issue

t511203 commented 3 years ago

Placed into draft while I rename some of the fields - I think some of the current names are a bit confusing as they're too similar to one another.

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@1d40743). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #928   +/-   ##
==========================================
  Coverage           ?   50.34%           
  Complexity         ?      125           
==========================================
  Files              ?       42           
  Lines              ?     1601           
  Branches           ?      130           
==========================================
  Hits               ?      806           
  Misses             ?      741           
  Partials           ?       54           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d40743...6beb4bd. Read the comment docs.

t511203 commented 3 years ago

Overall looks good, how do we feel about not being able to use EdgeSeeds? Could this be added too or is there just no need for it?

It's a significant amount of work to implement EdgeSeeds into the UI, so this would need to be carried out under another ticket (and triaged/prioritised appropriately).