Closed t511203 closed 3 years ago
Placed into draft while I rename some of the fields - I think some of the current names are a bit confusing as they're too similar to one another.
:exclamation: No coverage uploaded for pull request base (
develop@1d40743
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #928 +/- ##
==========================================
Coverage ? 50.34%
Complexity ? 125
==========================================
Files ? 42
Lines ? 1601
Branches ? 130
==========================================
Hits ? 806
Misses ? 741
Partials ? 54
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1d40743...6beb4bd. Read the comment docs.
Overall looks good, how do we feel about not being able to use
EdgeSeeds
? Could this be added too or is there just no need for it?
It's a significant amount of work to implement EdgeSeed
s into the UI, so this would need to be carried out under another ticket (and triaged/prioritised appropriately).
<seed-builder>
component to allow users to override the seed type that is inferred by the UI when submitting operations to Gaffer.overriddenSeedType
) is propagated through to theOperationChainController
, where it is used to change the seed formatting.Notes:
GetElements
operation through the UI which contains input with correctly formattedEdgeSeeds
andEntitySeeds
). All input seeds must be overridden to the same type.input
andinputB
), if the input seed type is overridden then this will apply to bothinput
andinputB
.EdgeSeeds
are still unsupported when using the UI.Related Issue