gchq / gaffer-tools

gaffer-tools is deprecated. Use https://github.com/gchq/gafferpy instead
Apache License 2.0
50 stars 29 forks source link

gh-896: Tidy up gafferpy parameter validation #929

Closed t92549 closed 3 years ago

t92549 commented 3 years ago

This PR updates the pattern of validating and assigning parameters from something like: https://github.com/gchq/gaffer-tools/blob/1d4074367f616d0d6ed32244eb5da9b67c5dcb4a/python-shell/src/gafferpy/gaffer_operations.py#L2320-L2328 to: https://github.com/gchq/gaffer-tools/blob/97e8185b605b84ac625c54d0565a72bda3fc0b37/python-shell/src/gafferpy/gaffer_operations.py#L2306

Not only does this clean up the code base and offer a unified way of validating inputs, it cleans up a lot of bugs where this was done not quite right.

Related Issue