search

gchq / gaffer-tools

gaffer-tools is deprecated. Use https://github.com/gchq/gafferpy instead
Apache License 2.0
50 stars 29 forks source link

gh-984: Change usage of log4j to slf4j #985

Closed t92549 closed 2 years ago

t92549 commented 2 years ago

Related Issue

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@684a765). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #985   +/-   ##
==========================================
  Coverage           ?   50.50%           
  Complexity         ?      125           
==========================================
  Files              ?       42           
  Lines              ?     1596           
  Branches           ?      130           
==========================================
  Hits               ?      806           
  Misses             ?      736           
  Partials           ?       54

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 684a765...f35aa54. Read the comment docs.

t92549 commented 2 years ago

I see you also made an improvement by combining some bits into one call, good stuff.

They were actually required because slf4j logger doesn't let you just log an Object. But yes I am glad it got flagged as the usage is nicer now.