Tidy tests for ingest job runner & task runner

gchq / sleeper

A cloud-native, serverless, scalable, cheap key-value store

Apache License 2.0

53 stars 11 forks source link

Tidy tests for ingest job runner & task runner #2713

Closed patchwork01 closed 2 days ago

patchwork01 commented 2 weeks ago

Background

IngestJobRunner and ECSIngestTaskRunner are currently covered by two test classes:

IngestJobRunnerIT
ECSIngestTaskRunnerIT

Description

We'd like to see if it would simplify our tests to unify these two test classes.

We'd like to consider tidying up the tests and adjusting use of helpers if appropriate.

Analysis

patchwork01 commented 3 days ago

Things are looking quite a bit tidier after the changes in the following issue:

https://github.com/gchq/sleeper/issues/2793

I'm not sure if we need any more tidying, since ECSIngestTaskRunnerIT mainly provides integration coverage between IngestTask, IngestJobRunner and IngestJobQueueConsumer. It seems cleaner to test IngestJobRunner on its own as we are now, rather than combining it into the larger integration test.

patchwork01 commented 2 days ago

The two classes test different things and there's not much overlap any more. Closing.