gchudov / cuetools.net

CD image processing suite with optimized lossless encoders in C#
http://cue.tools/
Other
480 stars 51 forks source link

Add support for AIFF #298

Closed DarkVoyage closed 10 months ago

DarkVoyage commented 11 months ago

Should be no problem to add at least as input format with ffmpeg. It is common for Apple users, who download and share aiff from Bandcamp and rip CDs too.

ha-korth commented 11 months ago

In the meantime you can add it yourself. Some examples here https://hydrogenaud.io/index.php?msg=1020471 (tagging is not supported) EDIT: You can use the keyboard INSERT key on all three tabs to add each new format/encoder/decoder. You need to provide ffmpeg.exe.

DarkVoyage commented 11 months ago

Thanks for info. It is usable for external formats. But it would be better, if you just add internal support with ffmpeg.dll, because this is one of basic formats that should be supported.

c72578 commented 11 months ago

@DarkVoyage Could you please test the build provided here: https://github.com/gchudov/cuetools.net/pull/299

DarkVoyage commented 11 months ago

It doesn't work. It gives following message and then CueTools crashes after any action. X:......aiff: Specified method is not supported..

By the way, TAK can be decoded by ffmpeg, may remove the need for takc.exe for those, who don't need to encode.

c72578 commented 11 months ago

@DarkVoyage Did you copy the required ffmpeg 6.0 dlls to plugins\x64 ?

Otherwise the exception, which you have observed, will appear: Exception_Specified_method_is_not_supported

Download links for the ffmpeg 6.0 dlls can be found e.g. here: https://github.com/gchudov/cuetools.net/pull/276#issuecomment-1516895823

DarkVoyage commented 11 months ago

Ok. It works. Thanks.