gchudov / cuetools.net

CD image processing suite with optimized lossless encoders in C#
http://cue.tools/
Other
480 stars 51 forks source link

Allow decoding aiff using ffmpeg.dll #299

Closed c72578 closed 10 months ago

c72578 commented 11 months ago

Screenshot of aiff added to Settings - Formats, taken from CUETools_2.2.4_2023-10-12_git_955881a_Allow_decoding_aiff_using_ffmpeg.dll.zip:

Settings_Formats_2_aiff_added_no_scrollbars

c72578 commented 11 months ago

Here is a build for testing, which allows decoding aiff using ffmpeg.dll: CUETools_2.2.4_2023-10-12_git_955881a_Allow_decoding_aiff_using_ffmpeg.dll.zip SHA256: 1ccad37c7a5c4ac19ad9ffeff340fb4b3120da14ead078070f059ce11a88a3aa

ha-korth commented 11 months ago

Seems okay. Used x64 dlls from https://github.com/GyanD/codexffmpeg/releases/download/6.0/ffmpeg-6.0-full_build-shared.zip The aiff format was not added/created when using old settings.txt file. I had to add the aiff format manually. When I deleted old settings file, aiff format is added to new settings file.

ha-korth commented 11 months ago

Screenshot of Formats tab using an existing settings.txt file CUETools_2.2.4_2023-10-12_git_955881a_Allow_decoding_aiff_using_ffmpeg.dll format Still have to add aiff to Formats manually or create a new settings.txt file from scratch

Decoders tab with existing settings file decoders

c72578 commented 11 months ago

@ha-korth Thanks for testing and having a look at the behavior with settings.txt files from previous versions.

These are the differences in the settings file, now that aiff has been added:

--- a/settings.txt  2023-10-14 07:04:29.980588600 +0200
+++ b/settings.txt  2023-10-14 07:11:46.803033300 +0200
@@ -250,6 +250,9 @@
 =      "$type": "CUETools.Codecs.ffmpegdll.MpegDecoderSettings, CUETools.Codecs.ffmpegdll"
 =    },
 =    {
+=      "$type": "CUETools.Codecs.ffmpegdll.AiffDecoderSettings, CUETools.Codecs.ffmpegdll"
+=    },
+=    {
 =      "$type": "CUETools.Codecs.Flake.DecoderSettings, CUETools.Codecs.Flake"
 =    },
 =    {
@@ -412,7 +415,15 @@
 CustomFormat14AllowLossless=1
 CustomFormat14AllowLossy=0
 CustomFormat14AllowEmbed=0
-CustomFormats=15
+CustomFormat15Name=aiff
+CustomFormat15EncoderLossless=
+CustomFormat15EncoderLossy=
+CustomFormat15Decoder=ffmpeg.dll
+CustomFormat15Tagger=0
+CustomFormat15AllowLossless=1
+CustomFormat15AllowLossy=0
+CustomFormat15AllowEmbed=0
+CustomFormats=16
 CustomScript0Name=default
 CustomScript0Condition0=1
 CustomScript0Condition1=0