Preserve settings for builtin formats

gchudov / cuetools.net

CD image processing suite with optimized lossless encoders in C#

http://cue.tools/

Other

480 stars 51 forks source link

Preserve settings for builtin formats #301

Closed c72578 closed 10 months ago

c72578 commented 10 months ago

The settings of builtin formats were not disabled anymore in Settings - Formats since e1f8906 (last working in release: 2.1.7). They were only disabled at the first start of CUETools. As soon as a settings.txt file was available, this was not the case anymore.

Furthermore, this fixes availability of newly added formats like aiff, if a settings.txt file from a previous version of CUETools is already present.

c72578 commented 10 months ago

Here is a build for testing: CUETools_2.2.4_2023-10-21_git_71488ef_Preserve_settings_for_builtin_formats.zip SHA256: 41e1d179380af92ba6093dcf22ce58b0958228b088520f9f1cad3da74bc1498c

@ha-korth, could you please have a look.

ha-korth commented 10 months ago

Locking Encoders, Decoders, and Advanced tabs now. No new encoders/decoders saved on restart. Encoder/decoder setting changes revert back to default on restart. Advanced options changes revert back to default on restart.

c72578 commented 10 months ago

@ha-korth thanks for testing and the feedback. The PR has been updated. Here is a new build for testing: CUETools_2.2.4_2023-10-21_git_6eae07c_Preserve_settings_for_builtin_formats.zip SHA256: a5ef5b29da316c75cb90dd66f6e7be758f68c2f78def5b297fb6350aa533f6a1

ha-korth commented 10 months ago

Initial run-through looks good. Previous settings/changes preserved. Encoders, Decoders, and Advanced tabs okay. Formats tab okay. Profile test looks good also.