search

gchudov / cuetools.net

CD image processing suite with optimized lossless encoders in C#
http://cue.tools/
Other
480 stars 51 forks source link

[CUERipper] Image rip (Embedded and + CUE) issues. #322

Open ha-korth opened 4 months ago

ha-korth commented 4 months ago

By default, when you rip to an Image, CUERipper embeds a CUE sheet tag and creates a separate .cue file.

Issue#1 CUERipper embeds a CUE sheet tag even when the format/container doesn't support it (e.g. .mp3, .m4a, .wma, .ogg, .opus, etc.). In CUETools, the CustomFormat##AllowEmbed=0 option prevents the user from selecting Embedded by graying it out. The same check doesn't seem present in CUERipper.

Issue#2 The CreateCUEFileWhenEmbedded=0 option allows the CUERipper user to create an Image with embedded CUE sheet tag without creating a separate .cue file (like CUETools does by unticking Create .cue file even if embedded). However, when the format/container doesn't support an embedded CUE sheet tag (e.g. .wav, .tta, .mp3, .m4a, .wma, .ogg, .opus, etc.) you could have an Image without a CUE sheet. If there is a 'check' added for issue#1 (or even if there isn't), there should be a check that would do something like

if CustomFormat##AllowEmbed=0 then force CreateCUEFileWhenEmbedded=1 (or some other way to force a .cue file)

Observation There doesn't seem to be an option in CUERipper to create Image + CUE without embedding a CUE sheet tag (like CUEStyle=1 in CUETools)