search

gchudov / cuetools.net

CD image processing suite with optimized lossless encoders in C#
http://cue.tools/
Other
480 stars 51 forks source link

Update SCSIDrive.cs to add support for LITEON ADH20A4P9P57 devices #328

Closed TomDSilva closed 3 months ago

TomDSilva commented 3 months ago

Added "ADH20A4P9P57" to the list of devices to use Mode296 as this device is not compatible with Mode294.

TomDSilva commented 3 months ago

Using a LITEON external USB DVD drive - model DX-20A4P throws the following error when ripping a CD: image

Upon testing, this appears to be because the hardware does not support Mode294 and needs to use Mode296. Using the code change I want to merge fixes this issue.

Here is a picture of the drive: image

And here is how the drive shows when in Visual Studio: image I have elected to target the drive name of "ADH20A4P9P57" as I believe this may be picked up also if the drive is used internally rather than in a USB enclosure as I am using (as I am omitting the "ATAPIDVD" part).

Please let me know if more information is needed, or if there is anything I need to change.

Thanks.

c72578 commented 3 months ago

@TomDSilva Thanks for your PR. Could you please post a screenshot of CUERipper showing the detected drive? It looks like the firmware version 9P57 is included in the string ADH20A4P9P57, which is not necessary.

DH20A4P is probably sufficient as identifier. https://www.daefeatures.co.uk/search?model=20A4P

TomDSilva commented 3 months ago

@c72578 of course: image

Just "DH20A4P" works, you are correct, thanks for the explanation. I have amended the commit to just target "DH20A4P", is that okay? I have never committed to someone else's work, so please be patient with me. :)

c72578 commented 3 months ago

Could you please move the added lines for the LITEON drive between the LG and MATSHITA drives? The lines are sorted alphabetically by manufacturer.

TomDSilva commented 3 months ago

@c72578, of course - done. Please let me know if anything more is needed.