search

gchux / cloud-run-tcpdump

Cloud Run packet capturing sidecar
Apache License 2.0
7 stars 2 forks source link

[FR] Assess whether we should use Cloud Run's built in GCS volume mount feature in place of GCSFuse directly #12

Open thomasmburke opened 3 months ago

thomasmburke commented 3 months ago

Should we use Cloud Run's built in GCS volume mount feature on the pcap sidecar container instead of GCSFuse directly?

The advantage it provides is when developers look at the sidecar container in the console they'll see the Volume mount configured and it will just make the sidecar make a bit more sense for folks that don't read the README carefully. I also suspect it will check GCS IAM permissions for us and have better error messages in that regard.

For non Cloud Run environments we'll still have to use GCSFuse directly and built out a function to detect the execution env. Alternatively, guard this option with yet another flag.

thomasmburke commented 3 months ago

GCS volume mounts have now reached the GA launch phase