GCS_DIR is not dynamic - Githubissues

gchux / cloud-run-tcpdump

Cloud Run packet capturing sidecar

Apache License 2.0

6 stars 0 forks source link

Open itsmais opened 1 month ago

itsmais commented 1 month ago

Currently, GCS_DIR's parent directory is set to match the GOOGLE_CLOUD_PROJECT string, ref https://github.com/gchux/cloud-run-tcpdump/blob/main/scripts/init#L48

It would be nice if either:

I get to choose a subdirectory in a bucket where pcaps are uploaded (while maintaining the original subpath format env/service-name/region/etc.)
We have a more expressive subdirectory name by default.

gchux commented 3 weeks ago

agreed, this is a good idea.

@itsmais would you be able to make it land into v1.0.60 ( in 2w ) ?