gcivil-nyu-org / INET-Monday-Fall2023-Team-3

2 stars 4 forks source link

Issues with manually added courses #73

Open ManaliTanna opened 11 months ago

ManaliTanna commented 11 months ago
  1. Dependency verification fails for manually added courses for example if I add "Advanced Database Systems" it will work.
  2. There is no check to see if the manually added course is valid or not, a user can enter "xyz" and get away with it. Not sure how to handle this or if there is even a way to do so, but it's something to think about anyway!
  3. When we edit a manually added course if I don't make any changes or just rewrite the same thing then it does not allow me to click save. Maybe provide a cancel button?
  4. Course does not get created if a description is not provided and there's no error message to handle that as well.
  5. Sometimes edge creation is not working, please see the screen recording, I was unable to recreate that behaviour again

Find attached screenshots and screen recordings.

Private Zenhub Video

Private Zenhub Video

Private Zenhub Video

Private Zenhub Video

mkZH0740 commented 11 months ago

thanks for the videos!

  1. We are not checking any course dependency the user added manually, because we are focusing on course planning right now. We can see if it is possible for us to add that if we have time.
  2. We support custom nodes in the planner mainly to let the user input whatever they want to input, for example, "html" or "css", so we are not checking the name of the custom node.
  3. Will look into that during this sprint
  4. Will look into that during this sprint
  5. I am not sure what's happening as well, maybe check the developer console to see if theres any error there?