gcivil-nyu-org / INET-Monday-Fall2023-Team-3

2 stars 4 forks source link

Can manually make a class node identical (maybe not bug?) #79

Open agoluoglu opened 11 months ago

agoluoglu commented 11 months ago

The document says "For pre-existing NYU courses, for example CS-GY 6063, once users added this course, then this course should no longer be displayed on the Add Node dialog." If this is to prevent multiples of the same course being added as nodes, then there is a situation where I can simply manually enter the exact same information. If this is okay, then maybe users should have the option to add just add the same predefined nodes more than once rather than having to do it manually. If it is not okay, then maybe the app should check if that title is already taken before allowing it to save.

Side note: at the end of the video I was looking at some of the comment features and noticed some weird behavior (dates are ordered nov 18, then 15, then 17 so not properly sorted by time), but noticed it is partially mentioned in your document under not to test, so I am not raising an issue. But I still think the footage could be useful, so I did not edit it out.

https://github.com/gcivil-nyu-org/INET-Monday-Fall2023-Team-3/assets/119933910/5d48eb03-4c85-4927-9d71-d0c5ef023a47

mkZH0740 commented 11 months ago

Thank you for the video! According to our design, users are allowed to input anything they want for custom nodes, its just that they will not be able to use the verify dependency feature on their own nodes. We are focusing on course planning right now, so I think maybe it's better to not have duplicate nodes referring to the same course?