gcivil-nyu-org / INET-Monday-Fall2023-Team-5

3 stars 5 forks source link

When a logged in user ends the game, but the second user is not logged in or is not notified of the change to navigate to the end url the game doesn’t end. #243

Closed AndresZarta closed 10 months ago

AndresZarta commented 10 months ago

When a logged in user ends the game, but the second user is not logged in or is not notified of the change to navigate to the end url, the game doesn’t end completely for the first user.

This is due to the way the end_game logic is implemented, requiring one player to end the game, the other to confirm. We can change that logic, but I also think it would be beneficial to rethink how we check for the existence of a game session: (Should it be about its absence in the database or its state being "Inactive" or "Ended".

aya0221 commented 10 months ago