search

gcivil-nyu-org / match-a-pet

0 stars 1 forks source link

Swipe retry #195

Closed shrutiagarwal28 closed 3 years ago

shrutiagarwal28 commented 3 years ago

@gururaj3

  1. Style.css has fff colors changed to FFFF, making things whiter, that's all.
  2. I need the swiper.js and base2.html for testing the added functions before I integrate them. Will disconnect and delete them once the enhancement is fully integrated.
  3. The css changes don't cause any visible change to the UI. Discussed these with Ben about making things whiter
gururaj3 commented 3 years ago

@shrutiagarwal28 - I think we should not add any files that are meant for testing. I think it would be good if we remove those 2 files because it is our staging and eventually will be pushed to production.

@benji7890 - Can you review the UI changes and if everything looks good, please approve the PR.

shrutiagarwal28 commented 3 years ago

@gururaj3 yeah, but I'll be anyway deleting these files in a future commit.

shrutiagarwal28 commented 3 years ago

@shrutiagarwal28

I am approving the PR and you can go ahead and merge it.

But I am going to make it clear that we should not be adding any testing related files to staging and production. Any testing related work is done on the personal branches/ dev and after everything is working as expected - then we go and create a PR for staging and production.

@gururaj3 yeah, of course. Since this is partly completed I wanted it to be there; I'll definitely be deleting the replica files as soon as we have the completed functionality. Thanks.