search

gcivil-nyu-org / nycCivilServiceJobs

4 stars 3 forks source link

Email verification upon registration not working #122

Open rahulgarg97 opened 3 years ago

rahulgarg97 commented 3 years ago

Issue tracker is ONLY used for reporting bugs. New features should be discussed in its own thread on the #general channel of slack.

Expected Behavior

When a new user signs up, they enter all of their details including their email. Then after clicking the Submit button, they should get an email to verify their registeration.

Current Behavior

When a new user signs up, they enter all of their details including their email. Then the user doesn't get an email to verify their registration. Their account is created straight away.

Ideas for Improvement

Steps to Reproduce

  1. Just sign up for a new account with any email.
  2. The email will not be verified and their account will be created straight away.
  3. The testing document says that the user will get an email with the link to login into their account.
  4. The user doesn't get any such email.

Context (Environment)

If the user provides someone else's email while creating their account or even by mistake they mess up a letter/some letters while providing their email id, their account is created and they subscribe to some exams, the user won't get the email notifications because the email was incorrect and didn't belong to that specific user. Some other user might get emails who didn't even sign up for this service.

gauravag2207 commented 3 years ago

Hi @rahulgarg97 , This would a good enhancement but it's not a bug. This is how the website is designed as of now and the same is mentioned in the testing guide as well. Please review

Also, the bug template says the below so I think this issue is not qualified as a bug. "Issue tracker is ONLY used for reporting bugs. New features should be discussed in its own thread on the #general channel of slack."

Thanks, nycCivilServiceJobs Team

i-rahman commented 3 years ago

Thanks Gaurav for getting to it!

@rahulgarg97, you should receive an email of the following template:

Hi [User First Name],

Thank you for registering with us! Please click the below link to sign in. http://nyc-civil-service-jobs.herokuapp.com/signin/

Thank You, nycCivilServiceJobs Team

As Gaurav mentioned, this would be an enhancement and actually a good one :)

rahulgarg97 commented 3 years ago

I suppose, the testing document for that part was confusing. <On successful registration, the user should get an email confirmation with the login url present in it.> I thought, "successful registration" means, that the user will receive a verification email. Now that it's not the case, you are good to go.

i-rahman commented 3 years ago

@rahulgarg97 please do add this as a suggestion in the #general channel of slack. We will love to keep track of it since you have put significant amount of effort in testing our app :)

nycCivilServiceJobs Team

joshganguly commented 3 years ago

@rahulgarg97 Thank you for testing and raising this enhancement. As mentioned in the testing guide document, it is a confirmation email with a login URL link (and not a verification email with a verification URL link).

Closing out this issue as it is not a bug.

joshganguly commented 3 years ago

Per the new guidelines for handling enhancements (on Github vs Slack), we'll be re-opening this ticket for tracking. We are looking into an enhancement to include email verification if time permits.